Support Date and Timestamp hive type partition columns in LegacyHiveT… #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenodaguirguis
left a comment
shenodaguirguis
left a comment
There was a problem hiding this comment.
Thanks for this patch @rzhang10!
Couple minor comments.
hive-metastore/src/main/java/org/apache/iceberg/hive/legacy/HiveExpressions.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| public void testToPartitionFilterStringEscapeStringLiterals() { |
| import static org.apache.iceberg.hive.legacy.HiveExpressions.toPartitionFilterString; | ||
|
|
||
|
|
||
| public class TestHiveExpressions { |
There was a problem hiding this comment.
can we add tests for DATE and TIMESTAMP (and other datatypes we should support)?
Member
Author
|
Please review #78 , which is a superset of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
LegacyHiveTableScanonly supports hive partition columns of string type, this patch leverage theBinderto augment the expressions (literals) with their corresponding types information and feed it toExpressionToPartitionFilterString, thus has the power to handle different partition column types such asTimestampandDate.After this patch, iceberg can support reading partitioned tables in our existing hive metastore which has
dateandtimestamptyped partition columns.