Skip to content

Stop using serdeToFileFormat to unblock formats other than Avro or Orc #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzhang10 merged 2 commits into from
Apr 13, 2021
Merged

Stop using serdeToFileFormat to unblock formats other than Avro or Orc #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6146cc7
Stop using serdeToFileFormat to unblock formats other than Avro or Orc
rzhang10 Apr 12, 2021
b69934c
Fix style check
rzhang10 Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hive-metastore/src/main/java/org/apache/iceberg/hive/legacy/LegacyHiveTableUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ static Schema getSchema(org.apache.hadoop.hive.metastore.api.Table table) {
org.apache.avro.Schema avroSchema = schemaStr != null ? new org.apache.avro.Schema.Parser().parse(schemaStr) : null;
Schema schema;
if (avroSchema != null) {
FileFormat format = serdeToFileFormat(table.getSd().getSerdeInfo().getSerializationLib());
String serde = table.getSd().getSerdeInfo().getSerializationLib();
org.apache.avro.Schema finalAvroSchema;
if (format.equals(FileFormat.AVRO) || HasDuplicateLowercaseColumnNames.visit(avroSchema)) {
if (serde.equals("org.apache.hadoop.hive.serde2.avro.AvroSerDe") ||
HasDuplicateLowercaseColumnNames.visit(avroSchema)) {
// Case 1: If serde == AVRO, early escape; Hive column info is not reliable and can be empty for these tables
// Hive itself uses avro.schema.literal as source of truth for these tables, so this should be fine
// Case 2: If avro.schema.literal has duplicate column names when lowercased, that means we cannot do reliable
Expand Down