[#2039] Support default value semantics - first PR: API changes #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmoustafa
reviewed
Apr 12, 2021
shardulm94
reviewed
Apr 13, 2021
shardulm94
reviewed
Apr 15, 2021
api/src/test/java/org/apache/iceberg/types/TestNestedFiledDefaultValues.java
Outdated
Show resolved
Hide resolved
wmoustafa
approved these changes
Apr 20, 2021
Contributor
|
I feel we should wait for some time to get early feedback from the community to make sure we agree on a high level. This should help reduce churn in our codebase. Most of my comments in apache/iceberg#2496 (review) are valid for the latest set of changes pushed by @shenodaguirguis and I hope they can be addressed before we merge this internally. |
wmoustafa
reviewed
Apr 30, 2021
wmoustafa
reviewed
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding defaultValue and its APIs to Iceberg Types.NestedField to support default values semantics (issue #2039).
This is PR 1 of 5.
For detailed problem and solution check defaultValueSupport.md