Skip to content

Hive: Fix uppercase bug and determine catalog from table properties #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shardulm94 merged 2 commits into from
Oct 2, 2020
Merged

Hive: Fix uppercase bug and determine catalog from table properties #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ea309
Hive: Return lowercase fieldname from IcebergRecordStructField
HotSushi Oct 2, 2020
b0c6e8a
Hive: Determine catalog from table property
HotSushi Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mr/src/main/java/org/apache/iceberg/mr/Catalogs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ public static Table loadTable(Configuration conf) {

// For use in HiveIcebergSerDe and HiveIcebergStorageHandler
public static Table loadTable(Configuration conf, Properties props) {
Optional.ofNullable(props.getProperty(InputFormatConfig.CATALOG))
.ifPresent(x -> conf.set(InputFormatConfig.CATALOG, x));
return loadTable(conf, props.getProperty(NAME), props.getProperty(LOCATION));
}

Expand Down
2 changes: 1 addition & 1 deletion ...n/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergRecordObjectInspector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ private static class IcebergRecordStructField implements StructField {

@Override
public String getFieldName() {
return field.name();
return field.name().toLowerCase();
}

@Override
Expand Down