Skip to content

Hive Metadata Scan: Notify ScanEvent listeners on planning #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdsr merged 1 commit into from
Aug 19, 2020
Merged

Hive Metadata Scan: Notify ScanEvent listeners on planning #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions hive/src/main/java/org/apache/iceberg/hive/legacy/LegacyHiveTableScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,24 @@
import org.apache.iceberg.TableOperations;
import org.apache.iceberg.TableScan;
import org.apache.iceberg.TableScanContext;
import org.apache.iceberg.events.Listeners;
import org.apache.iceberg.events.ScanEvent;
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.expressions.ResidualEvaluator;
import org.apache.iceberg.io.CloseableIterable;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
import org.apache.iceberg.util.ParallelIterable;
import org.apache.iceberg.util.ThreadPools;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;


/**
* A {@link DataTableScan} which uses Hive table and partition metadata to read tables.
* This scan does not provide any time travel, snapshot isolation, incremental computation benefits.
*/
public class LegacyHiveTableScan extends DataTableScan {
private static final Logger LOG = LoggerFactory.getLogger(LegacyHiveTableScan.class);

protected LegacyHiveTableScan(TableOperations ops, Table table) {
super(ops, table);
Expand All @@ -62,6 +67,11 @@ protected TableScan newRefinedScan(TableOperations ops, Table table, Schema sche

@Override
public CloseableIterable<FileScanTask> planFiles() {
LOG.info("Scanning table {} with filter {}", table().toString(), filter());

Listeners.notifyAll(
new ScanEvent(table().toString(), -1, filter(), schema()));

LegacyHiveTableOperations hiveOps = (LegacyHiveTableOperations) tableOps();
PartitionSpec spec = hiveOps.current().spec();
String schemaString = SchemaParser.toJson(spec.schema());
Expand Down