Fix missing Spark flow and job info. #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayortigas
commented
Jan 29, 2017
| @@ -147,4 +152,62 @@ public void testGetSchedulerInstanceNull() { | |||
| assertEquals(null, scheduler); | |||
There was a problem hiding this comment.
assertNull would be more obvious, I think, but I tried to limit the scope of the changes in this PR.
rayortigas
commented
Jan 29, 2017
| assertFalse(StringUtils.isEmpty(result.getJobDefUrl())); | ||
| assertFalse(StringUtils.isEmpty(result.getFlowExecUrl())); | ||
| assertFalse(StringUtils.isEmpty(result.getFlowDefUrl())); | ||
| } |
There was a problem hiding this comment.
There's probably a Hamcrest matcher we could use here, but combining assertFalse with StringUtils.isEmpty seems to be good enough.
rayortigas
commented
Jan 29, 2017
| @@ -234,11 +234,12 @@ public static int getHeuristicScore(Severity severity, int tasks) { | |||
| * | |||
| * @param field the field to br truncated | |||
| * @param limit the truncation limit | |||
| * @param context additional context for logging purposes | |||
There was a problem hiding this comment.
I was wondering why truncateField was taking an appId, then I saw what was going on here. Hopefully this change helps.
rayortigas
commented
Jan 29, 2017
| properties = retrieveMapreduceProperties((MapReduceApplicationData) data); | ||
| } | ||
|
|
||
| Properties properties = data.getConf(); |
There was a problem hiding this comment.
After #162, getConf should be sufficient for both MapReduceApplicationData and SparkApplicationData.
|
Closing this. Please check #162 for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing Spark flow and job info (e.g. execution and definition URLs), which I broke after #162