Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding enum for nested json support #86

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

gautamshanu
Copy link
Contributor

@gautamshanu gautamshanu commented Feb 5, 2025

Dear DIL maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • My PR addresses the following JIRA issues and references them in the PR title.

Description

  • Here are some details about my PR, including screenshots (if applicable):

For JsonExtractor, while fetching the schema as part of extraction, we set the row filter.
This row filter is a JsonSchemaBasedFilter. For this, we try to convert each element from the output schema of the job configs into a JisColumn.
This needs us to set the data type. When this type is a map, the flow fails, because we don't have a MAP type under JsonElementTypes to set as the data type.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Collaborator

@avinas-kumar avinas-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinas-kumar avinas-kumar merged commit 8840cda into linkedin:master Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants