Add more logging to help debugging the time spent on goal based operation #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groelofs
approved these changes
Oct 1, 2024
mhratson
reviewed
Oct 2, 2024
...control/src/main/java/com/linkedin/kafka/cruisecontrol/async/progress/OperationProgress.java
Outdated
Show resolved
Hide resolved
.../linkedin/kafka/cruisecontrol/servlet/handler/async/runnable/GoalBasedOperationRunnable.java
Outdated
Show resolved
Hide resolved
.../linkedin/kafka/cruisecontrol/servlet/handler/async/runnable/GoalBasedOperationRunnable.java
Outdated
Show resolved
Hide resolved
The pending status is the first step in handling |
…async/progress/OperationProgress.java Co-authored-by: Maryan Hratson <[email protected]>
…servlet/handler/async/runnable/GoalBasedOperationRunnable.java Co-authored-by: Maryan Hratson <[email protected]>
…servlet/handler/async/runnable/GoalBasedOperationRunnable.java Co-authored-by: Maryan Hratson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some cruise control operation, like broker removal, has to go through a few steps. It may also be in pending state for some time due to thread pool resource limitations or ongoing operations. We want to have additional observability on the time it takes for each step so that we know where the potential improvement will be.
Additional loggings are added to track the total time and time spent on each step for the goal based operation.
Categorization