Configurable prometheus path via config #2082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCisGG
reviewed
Dec 13, 2023
| @@ -105,13 +106,15 @@ private void configurePrometheusAdapter(Map<String, ?> configs) { | |||
| "%s config is required by Prometheus metric sampler", PROMETHEUS_SERVER_ENDPOINT_CONFIG)); | |||
| } | |||
|
|
|||
| final String path = (String) configs.get(PROMETHEUS_SERVER_PATH_CONFIG); | |||
There was a problem hiding this comment.
Just curious won't this cause NPE if PROMETHEUS_SERVER_PATH_CONFIG is not set?
There was a problem hiding this comment.
In theory, yes, but this is set a few lines up: https://github.com/linkedin/cruise-control/pull/2082/files/aeb29411e60ab15884c0f7696cc639ef81d00246#diff-d114eb44a5084d7894e3ddc1b1e00f52466bfd49f8c3b40383b8863534683c0fR55 and follows the existing pattern used for the Prometheus server endpoint.
|
#2120 may be a better solution for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2081.