Skip to content

Bump vulnerable transitive jackson-databind dependency#1810

Merged
efeg merged 1 commit into
linkedin:migrate_to_kafka_2_5from
lmr3796:migrate_to_kafka_2_5
Mar 31, 2022
Merged

Bump vulnerable transitive jackson-databind dependency#1810
efeg merged 1 commit into
linkedin:migrate_to_kafka_2_5from
lmr3796:migrate_to_kafka_2_5

Conversation

@lmr3796

@lmr3796 lmr3796 commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

There's a vulnerability in jackson-databind CVE-2020-36518, which gets
resolved in jackson-databind 2.12.6.1+/2.13.1+.

Cruise control transitively pulls vulnerable jackson version via
Apache Kafka 3.1.0. Apache Kafka 3.1.1 has the fix (see KAFKA-13775),
but it is not yet released. We can remove this pin and bump into 3.1.1
to resolve this after Kafka 3.1.1 is released.

@lmr3796

lmr3796 commented Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

Upstream kafka patch:
apache/kafka#11962

@lmr3796
lmr3796 requested a review from efeg March 31, 2022 17:45
@lmr3796
lmr3796 force-pushed the migrate_to_kafka_2_5 branch from 9902ee8 to 4b4930b Compare March 31, 2022 17:48
@lmr3796

lmr3796 commented Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

Build scan shows dependency got upgraded
Screen Shot 2022-03-31 at 10 48 47 AM

@efeg efeg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmr3796 Thanks for the PR!
Left some nits and a question.

Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
Comment thread build.gradle Outdated
@lmr3796
lmr3796 force-pushed the migrate_to_kafka_2_5 branch from 4b4930b to 2005180 Compare March 31, 2022 18:10

@efeg efeg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update -- left one more comment.

Comment thread build.gradle
@lmr3796
lmr3796 force-pushed the migrate_to_kafka_2_5 branch from 2005180 to 84e2682 Compare March 31, 2022 19:39
There's a vulnerability in jackson-databind CVE-2020-36518, which gets
resolved in jackson-databind 2.12.6.1+/2.13.1+.

Cruise control transitively pulls vulnerable jackson version via
Apache Kafka 3.1.0.  Apache Kafka 3.1.1 has the fix (See KAFKA-13775),
but it is not yet released.  We can remove this pin and bump into 3.1.1
to resolve this after Kafka 3.1.1 is released.
@lmr3796
lmr3796 force-pushed the migrate_to_kafka_2_5 branch from 84e2682 to cdf4938 Compare March 31, 2022 19:53
@efeg
efeg merged commit 8821897 into linkedin:migrate_to_kafka_2_5 Mar 31, 2022
efeg pushed a commit to efeg/cruise-control that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants