Drop enforcement that anomaly.detection.goals must be a subset of sel…

…f.healing.goals (if non-empty)
linkedin · Mar 25, 2021 · ff59d7c · ff59d7c
1 parent 2afccb2
commit ff59d7c
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/...ntrol/src/main/java/com/linkedin/kafka/cruisecontrol/config/KafkaCruiseControlConfig.java b/...ntrol/src/main/java/com/linkedin/kafka/cruisecontrol/config/KafkaCruiseControlConfig.java
@@ -113,9 +113,7 @@ public <T> T getConfiguredInstance(String key, Class<T> t, Map<String, Object> c
    *   <li>{@link AnalyzerConfig#DEFAULT_GOALS_CONFIG} is a subset of {@link AnalyzerConfig#GOALS_CONFIG}.</li>
    *   <li>{@link AnalyzerConfig#HARD_GOALS_CONFIG} is a subset of {@link AnalyzerConfig#DEFAULT_GOALS_CONFIG}.</li>
    *   <li>{@link AnomalyDetectorConfig#SELF_HEALING_GOALS_CONFIG} is a subset of {@link AnalyzerConfig#DEFAULT_GOALS_CONFIG}.</li>
-   *   <li>{@link AnomalyDetectorConfig#ANOMALY_DETECTION_GOALS_CONFIG} is a sublist of
-   *   (1) {@link AnomalyDetectorConfig#SELF_HEALING_GOALS_CONFIG} if it is not empty,
-   *   (2) {@link AnalyzerConfig#DEFAULT_GOALS_CONFIG} otherwise.</li>
+   *   <li>{@link AnomalyDetectorConfig#ANOMALY_DETECTION_GOALS_CONFIG} is a sublist of {@link AnalyzerConfig#DEFAULT_GOALS_CONFIG} otherwise.</li>
    * </ul>
    */
   private void sanityCheckGoalNames() {
@@ -181,13 +179,6 @@ private void sanityCheckGoalNames() {
                                               AnomalyDetectorConfig.SELF_HEALING_GOALS_CONFIG, selfHealingGoalNames,
                                               AnalyzerConfig.DEFAULT_GOALS_CONFIG, defaultGoalNames));
     }
-
-    // Ensure that goals used for anomaly detection are a subset of goals used for fixing the anomaly.
-    List<String> anomalyDetectionGoalNames = getList(AnomalyDetectorConfig.ANOMALY_DETECTION_GOALS_CONFIG);
-    if (anomalyDetectionGoalNames.stream().anyMatch(g -> selfHealingGoalNames.isEmpty() ? !defaultGoalNames.contains(g)
-                                                                                        : !selfHealingGoalNames.contains(g))) {
-      throw new ConfigException("Attempt to configure anomaly detection goals as a superset of self healing goals.");
-    }
   }
 
   /**