Removed skip_hard_goal_check parameter

Signed-off-by: ShubhamRwt <[email protected]>
linkedin · May 10, 2024 · de4b4a4 · de4b4a4
1 parent 8371064
commit de4b4a4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 14 deletions.
diff --git a/.../com/linkedin/kafka/cruisecontrol/servlet/handler/async/runnable/RemoveDisksRunnable.java b/.../com/linkedin/kafka/cruisecontrol/servlet/handler/async/runnable/RemoveDisksRunnable.java
@@ -49,7 +49,7 @@ public RemoveDisksRunnable(KafkaCruiseControl kafkaCruiseControl,
                                OperationFuture future,
                                RemoveDisksParameters parameters,
                                String uuid) {
-        super(kafkaCruiseControl, future, parameters, parameters.dryRun(), parameters.stopOngoingExecution(), parameters.skipHardGoalCheck(),
+        super(kafkaCruiseControl, future, parameters, parameters.dryRun(), parameters.stopOngoingExecution(), false,
                 uuid, parameters::reason);
         _brokerIdAndLogdirs = parameters.brokerIdAndLogdirs();
     }

diff --git a/.../main/java/com/linkedin/kafka/cruisecontrol/servlet/parameters/RemoveDisksParameters.java b/.../main/java/com/linkedin/kafka/cruisecontrol/servlet/parameters/RemoveDisksParameters.java
@@ -16,7 +16,6 @@
 import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.BROKER_ID_AND_LOGDIRS_PARAM;
 import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.DRY_RUN_PARAM;
 import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.REASON_PARAM;
-import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.SKIP_HARD_GOAL_CHECK_PARAM;
 import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.STOP_ONGOING_EXECUTION_PARAM;
 import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.JSON_PARAM;
 import static com.linkedin.kafka.cruisecontrol.servlet.parameters.ParameterUtils.VERBOSE_PARAM;
@@ -29,15 +28,13 @@ public class RemoveDisksParameters extends GoalBasedOptimizationParameters {
         validParameterNames.add(DRY_RUN_PARAM);
         validParameterNames.add(REASON_PARAM);
         validParameterNames.add(VERBOSE_PARAM);
-        validParameterNames.add(SKIP_HARD_GOAL_CHECK_PARAM);
         validParameterNames.add(STOP_ONGOING_EXECUTION_PARAM);
         validParameterNames.add(JSON_PARAM);
         CASE_INSENSITIVE_PARAMETER_NAMES = Collections.unmodifiableSortedSet(validParameterNames);
     }
     private boolean _dryRun;
     private String _reason;
     private boolean _verbose;
-    private boolean _skipHardGoalCheck;
     private boolean _stopOngoingExecution;
     private Map<Integer, Set<String>> _logdirByBrokerId;
 
@@ -51,7 +48,6 @@ protected void initParameters() throws UnsupportedEncodingException {
         _logdirByBrokerId = ParameterUtils.brokerIdAndLogdirs(_requestContext);
         _dryRun = ParameterUtils.getDryRun(_requestContext);
         _verbose = ParameterUtils.isVerbose(_requestContext);
-        _skipHardGoalCheck = ParameterUtils.skipHardGoalCheck(_requestContext);
         boolean requestReasonRequired = _config.getBoolean(ExecutorConfig.REQUEST_REASON_REQUIRED_CONFIG);
         _reason = ParameterUtils.reason(_requestContext, requestReasonRequired && !_dryRun);
         _stopOngoingExecution = ParameterUtils.stopOngoingExecution(_requestContext);
@@ -79,9 +75,6 @@ public String reason() {
     public boolean verbose() {
         return super.isVerbose();
     }
-    public boolean skipHardGoalCheck() {
-        return _skipHardGoalCheck;
-    }
     public boolean dryRun() {
         return _dryRun;
     }

diff --git a/cruise-control/src/main/resources/yaml/endpoints/removeDisks.yaml b/cruise-control/src/main/resources/yaml/endpoints/removeDisks.yaml
@@ -15,12 +15,6 @@ RemoveDisksEndpoint:
         schema:
           type: boolean
           default: false
-      - name: skip_hard_goal_check
-        in: query
-        description: Whether to allow hard goals be skipped in proposal generation.
-        schema:
-          type: boolean
-          default: false
       - name: verbose
         in: query
         description: Return detailed state information.