Add DeleteRamp to MigrationConfig for independent delete ramp control - #3273
Draft
beijxu wants to merge 1 commit into
Draft
Add DeleteRamp to MigrationConfig for independent delete ramp control#3273beijxu wants to merge 1 commit into
beijxu wants to merge 1 commit into
Conversation
Add a new DeleteRamp inner class to MigrationConfig, decoupling delete operations from the existing WriteRamp. This allows independent ramp control for deletes during storage backend migration. DeleteRamp fields mirror WriteRamp's delete-related pattern: - forceDisableDualDelete - dualDeleteAsyncPct - dualDeleteSyncPctNonStrict - dualDeleteSyncPctStrict - deleteOnlyToSecondary Backward compatibility: - The field defaults to null when absent from JSON (existing configs) - A 4-arg MigrationConfig constructor is preserved for existing callers - @JsonIgnoreProperties(ignoreUnknown = true) ensures forward compat Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3273 +/- ##
=============================================
- Coverage 64.24% 38.12% -26.12%
+ Complexity 10398 6463 -3935
=============================================
Files 840 938 +98
Lines 71755 80355 +8600
Branches 8611 9671 +1060
=============================================
- Hits 46099 30639 -15460
- Misses 23004 47225 +24221
+ Partials 2652 2491 -161 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
DeleteRampinner class toMigrationConfig, decoupling delete operations from the existingWriteRamp. This allows independent ramp control for deletes during storage backend migration.Changes
DeleteRampclass with fields:forceDisableDualDelete,dualDeleteAsyncPct,dualDeleteSyncPctNonStrict,dualDeleteSyncPctStrict,deleteOnlyToSecondarydeleteRampfield toMigrationConfig(nullable, defaults tonull)@JsonIgnoreProperties(ignoreUnknown = true)onDeleteRampfor forward compatibilityBackward Compatibility
deleteRampdeserializes successfully (getDeleteRamp()returnsnull)DeleteRampignores the new field via@JsonIgnoreProperties(ignoreUnknown = true)onMigrationConfigMigrationConfigconstructor still works (delegates withdeleteRamp=null)Testing Done
MigrationConfigTest: constructor, serialization round-trip, unknown field tolerance, backward-compat deserialization withoutdeleteRamp, equals/hashCode, default constructor, 4-arg constructor compatBackwardsCompatibilityTest: updated field set expectations, added snapshot-without-deleteRamp test, all existing snapshot tests pass unchanged