Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest without need to dealing with PYTHONPATH #95

Merged
merged 1 commit into from
Aug 26, 2024
Merged

pytest without need to dealing with PYTHONPATH #95

merged 1 commit into from
Aug 26, 2024

Conversation

helloworld1
Copy link
Collaborator

Summary

pytest without need to dealing with PYTHONPATH

According to pytest doc, python -m pytest will put current dir to sys.path, eliminating the need to add PYTHONPATH=. to make test passing

Testing Done

make

  • Hardware Type: AMD 7900 XTX
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@helloworld1 helloworld1 marked this pull request as ready for review August 26, 2024 16:02
@lancerts lancerts merged commit 8aab06a into linkedin:main Aug 26, 2024
1 check passed
ByronHsu
ByronHsu reviewed Aug 26, 2024
View reviewed changes
Makefile
.PHONY: test checkstyle test-convergence all


all: test test-convergence checkstyle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu left review comments

@lancerts lancerts lancerts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helloworld1 @lancerts @ByronHsu