Skip to content

A Fix for Issue #872 #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

A Fix for Issue #872 #879

merged 1 commit into from
Sep 11, 2025
+2 −1

Conversation

yshenaw
Copy link
Contributor

@yshenaw yshenaw commented Sep 10, 2025

Summary

This is a fix for Issue #872. @shimizust wants me to submit this fix.

@shimizust Could you have a look at the fix?

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@yshenaw yshenaw mentioned this pull request Sep 10, 2025
Open
shimizust
shimizust approved these changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@shimizust shimizust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@shimizust shimizust merged commit 0b34362 into linkedin:main Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimizust shimizust shimizust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yshenaw @shimizust