New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nn.module support for chunked loss function #402

Merged

ByronHsu merged 1 commit into main from shisahni/modular

Nov 21, 2024

Collaborator

shivam15s commented Nov 21, 2024 •

edited

Loading

Summary

Same as title

Testing Done

Hardware Type:
run make test to ensure correctness
run make checkstyle to ensure code style
run make test-convergence to ensure convergence


          add nn module for chunked loss functions

6b18146

ByronHsu approved these changes

View reviewed changes

Collaborator

ByronHsu left a comment

Nice interface!!

ByronHsu merged commit 2a39f0d into main

3 checks passed

ByronHsu deleted the shisahni/modular branch

November 21, 2024 05:45

Collaborator

ByronHsu commented Nov 21, 2024

Part of #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet