Disable gemma2 and qwen2_vl tests #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronHsu
previously approved these changes
Oct 1, 2024
tyler-romero
reviewed
Oct 1, 2024
| @@ -225,6 +225,9 @@ def run_mini_model_multimodal( | |||
| return {"loss": loss_list, "logits": output.logits, "model": model} | |||
|
|
|||
|
|
|||
| @pytest.mark.skip( | |||
| reason="This test needs to be fixed and work without access to HF Hub" | |||
| ) | |||
There was a problem hiding this comment.
This is the one-line fix, feel free to incorporate here: https://github.com/linkedin/Liger-Kernel/pull/283/files#diff-b42e5a7b27b3397cec9a04271eb7927150bf8cb04571f1093e4d329ff7c55838R143
ByronHsu
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
attn_implementation="eager"fixes the NaNs, but results don't pass convergence criteria. Will need to investigate further, but skipping these for now.Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence