Skip to content

Fix assert_verbose_allclose bugs #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 1, 2024
Merged

Fix assert_verbose_allclose bugs #261

merged 6 commits into from
Oct 1, 2024

Conversation

Tcc0403
Copy link
Collaborator

@Tcc0403 Tcc0403 commented Sep 20, 2024 •
edited
Loading

Summary

Fix #259

Adding more masks to cover all edge cases, including:

  • nan
  • inf
  • -inf

We should merge #262 before this PR to pass all tests.

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@ByronHsu ByronHsu mentioned this pull request Sep 30, 2024
Open
@lancerts lancerts enabled auto-merge (squash) October 1, 2024 21:39
@lancerts lancerts merged commit 16bde6c into linkedin:main Oct 1, 2024
2 checks passed
@Tcc0403 Tcc0403 deleted the test-utils-allclose branch December 1, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test.utils.assert_verbose_allclose has multiple bugs
3 participants
@Tcc0403 @ByronHsu @lancerts