Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish test/ and others #26

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Polish test/ and others #26

merged 1 commit into from
Aug 15, 2024

Conversation

ByronHsu
Copy link
Collaborator

Summary

as title

Testing Done

  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence
jobuser [ ~/Liger-Kernel ]$ make checkstyle && make test && make test-convergence
flake8 .; flake8_status=$?; \
isort .; isort_status=$?; \
black .; black_status=$?; \
if [ $flake8_status -ne 0 ] || [ $isort_status -ne 0 ] || [ $black_status -ne 0 ]; then \
        exit 1; \
fi
Skipped 1 files
All done! ✨ 🍰 ✨
45 files left unchanged.
pytest --disable-warnings test/ --ignore=test/convergence
================================================================================================== test session starts ===================================================================================================
platform linux -- Python 3.10.14, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/jobuser/Liger-Kernel
plugins: lipy-config-base-30.6.1, lipy-fabric-35.2.3, lipy-test-8.0.52, datadir-1.3.1, lipy-mp-34.4.191
collected 111 items                                                                                                                                                                                                      

test/transformers/test_cross_entropy.py ..........................................................                                                                                                                 [ 52%]
test/transformers/test_fused_linear_cross_entropy.py ......                                                                                                                                                        [ 57%]
test/transformers/test_geglu.py ........                                                                                                                                                                           [ 64%]
test/transformers/test_rms_norm.py ................                                                                                                                                                                [ 79%]
test/transformers/test_rope.py ............                                                                                                                                                                        [ 90%]
test/transformers/test_swiglu.py ........                                                                                                                                                                          [ 97%]
test/transformers/test_transformers_monkey_patch.py .                                                                                                                                                              [ 98%]
test/triton/test_triton_monkey_patch.py ..                                                                                                                                                                         [100%]

============================================================================================= 111 passed in 60.64s (0:01:00) =============================================================================================
HF_DATASETS_OFFLINE=1 pytest --disable-warnings test/convergence
================================================================================================== test session starts ===================================================================================================
platform linux -- Python 3.10.14, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/jobuser/Liger-Kernel
plugins: lipy-config-base-30.6.1, lipy-fabric-35.2.3, lipy-test-8.0.52, datadir-1.3.1, lipy-mp-34.4.191
collected 8 items                                                                                                                                                                                                        

test/convergence/test_mini_models.py ......                                                                                                                                                                        [ 75%]
test/convergence/test_mini_models_no_logits.py ..                                                                                                                                                                  [100%]

============================================================================================== 8 passed in 95.88s (0:01:35) ==============================================================================================

@ByronHsu ByronHsu merged commit 030cb71 into main Aug 15, 2024
@ByronHsu ByronHsu deleted the byhsu/polish-2 branch August 15, 2024 20:38
yundai424 pushed a commit that referenced this pull request Aug 16, 2024
## Summary
<!--- This is a required section; please describe the main purpose of
this proposed code change. --->

<!---
## Details
This is an optional section; is there anything specific that reviewers
should be aware of?
--->

as title

## Testing Done
<!--- This is a required section; please describe how this change was
tested. --->

<!-- 
Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them. 
-->

- [x] run `make test` to ensure correctness
- [x] run `make checkstyle` to ensure code style
- [x] run `make test-convergence` to ensure convergence

```
jobuser [ ~/Liger-Kernel ]$ make checkstyle && make test && make test-convergence
flake8 .; flake8_status=$?; \
isort .; isort_status=$?; \
black .; black_status=$?; \
if [ $flake8_status -ne 0 ] || [ $isort_status -ne 0 ] || [ $black_status -ne 0 ]; then \
        exit 1; \
fi
Skipped 1 files
All done! ✨ 🍰 ✨
45 files left unchanged.
pytest --disable-warnings test/ --ignore=test/convergence
================================================================================================== test session starts ===================================================================================================
platform linux -- Python 3.10.14, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/jobuser/Liger-Kernel
plugins: lipy-config-base-30.6.1, lipy-fabric-35.2.3, lipy-test-8.0.52, datadir-1.3.1, lipy-mp-34.4.191
collected 111 items                                                                                                                                                                                                      

test/transformers/test_cross_entropy.py ..........................................................                                                                                                                 [ 52%]
test/transformers/test_fused_linear_cross_entropy.py ......                                                                                                                                                        [ 57%]
test/transformers/test_geglu.py ........                                                                                                                                                                           [ 64%]
test/transformers/test_rms_norm.py ................                                                                                                                                                                [ 79%]
test/transformers/test_rope.py ............                                                                                                                                                                        [ 90%]
test/transformers/test_swiglu.py ........                                                                                                                                                                          [ 97%]
test/transformers/test_transformers_monkey_patch.py .                                                                                                                                                              [ 98%]
test/triton/test_triton_monkey_patch.py ..                                                                                                                                                                         [100%]

============================================================================================= 111 passed in 60.64s (0:01:00) =============================================================================================
HF_DATASETS_OFFLINE=1 pytest --disable-warnings test/convergence
================================================================================================== test session starts ===================================================================================================
platform linux -- Python 3.10.14, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/jobuser/Liger-Kernel
plugins: lipy-config-base-30.6.1, lipy-fabric-35.2.3, lipy-test-8.0.52, datadir-1.3.1, lipy-mp-34.4.191
collected 8 items                                                                                                                                                                                                        

test/convergence/test_mini_models.py ......                                                                                                                                                                        [ 75%]
test/convergence/test_mini_models_no_logits.py ..                                                                                                                                                                  [100%]

============================================================================================== 8 passed in 95.88s (0:01:35) ==============================================================================================
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant