compute quantiles for memory usage #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvignesh1420
changed the title
update CE and swiglu benchmarks add embedding benchmark results add flce benchmarks add geglu benchmarks add layernorm benchmarks add rms norm benchmarks add rope benchmarks lint fixes
kvignesh1420
force-pushed
the
add-quartile-mem-data
branch
from
b7dec57
to
66ac688
Compare
ByronHsu
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds quantile computations for memory usage during benchmarking.
Details
Currently, the
_test_memoryfunction only return the mean memory usage and does not return quantile data. This PR adds the necessary functionality and keeps it in sync with the speed based stats that triton benchmarks compute.Env:
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence