Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated sl to be non-constexpr #149

Merged
merged 2 commits into from
Aug 28, 2024
Merged

updated sl to be non-constexpr #149

merged 2 commits into from
Aug 28, 2024

Conversation

AndreSlavescu
Copy link
Contributor

Summary

updated seqlen for rope to be non-constexpr

sl from constexpr to non-constexpr

Testing Done

  • Hardware Type: RTX 3090
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@yundai424 yundai424 linked an issue Aug 28, 2024 that may be closed by this pull request
[Question] triton jit of LigerRopeFunction runs every step when variable length sequences are used #146
Closed
yundai424
yundai424 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@yundai424 yundai424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Tested with a mini script running on different seq len and validate that this works.

@yundai424 yundai424 merged commit c3c56e7 into linkedin:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yundai424 yundai424 yundai424 approved these changes

@ByronHsu ByronHsu ByronHsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] triton jit of LigerRopeFunction runs every step when variable length sequences are used
3 participants
@AndreSlavescu @ByronHsu @yundai424