Skip to content

Fix Convergence Tests for Transformers v5#1090

Merged
Tcc0403 merged 3 commits intolinkedin:transformers-5.0.0rc1from
Mecoli1219:fix-v5-convergence
Feb 10, 2026
Merged

Fix Convergence Tests for Transformers v5#1090
Tcc0403 merged 3 commits intolinkedin:transformers-5.0.0rc1from
Mecoli1219:fix-v5-convergence

Conversation

@Mecoli1219
Copy link
Collaborator

@Mecoli1219 Mecoli1219 commented Feb 10, 2026

Summary

Fix Convergence Tests for Transformers v5, including updating some mismatched variables, increasing the tolerance for some tests, ...etc. The only one error remained is expected and should be fixed in Transformers#43882.

Related Issues & PRs

Testing Done

  • Hardware Type: H100
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence on v4 & v5

Mecoli1219 and others added 2 commits February 10, 2026 08:30
Co-authored-by: Tcc0403 <76503978+Tcc0403@users.noreply.github.com>
Copy link
Collaborator

@Tcc0403 Tcc0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm

@Tcc0403 Tcc0403 merged commit 9ea2f92 into linkedin:transformers-5.0.0rc1 Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants