Add convergence tests and trainer integration test for Qwen2 #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discussion
Add convergence tests and trainer integration test for Qwen2
Details
Qwen2's config and parameters are copied from
test_cross_entropy.py
.I also added qwen2 mock in
test_apply_liger_kernel_only_supported_model_type_called
just in case. But are we going to add every new models from now on?Testing Done
I don't have a GPU with enough memory, only run
test_trainer_integration.py
andtest_transformers_monkey_patch.py
.Need others to help with
make test
.make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence