-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update applyPatch function and add tests for it #574
Conversation
766d539
to
67f47cd
Compare
Hi and thanks for your contribution. Can you please describe what bugs you experienced and how your changes fix those? |
The bugs I found:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the face of it this all seems to make sense.
Looking back at this now it is merged (and broken for solid-ui.) |
So the test is wrong too. The parameters are expected to be IndexedFormulas, not collections. Let's roll this back. Sorry I don't read it carefully in review. |
The
applyPatch
function had a few small bugs when I tried it, so I fixed those and added tests for the function