-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: --watch mode for extract and compile #974
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/6zZYi3M9gvzzLw6RrMAoV1A7masu |
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
=======================================
Coverage 83.30% 83.30%
=======================================
Files 53 53
Lines 1605 1605
Branches 430 430
=======================================
Hits 1337 1337
Misses 156 156
Partials 112 112 Continue to review full report at Codecov.
|
packages/cli/src/lingui-compile.ts
Outdated
const results = command(config, { | ||
verbose: program.verbose || false, | ||
const compile = () => command(config, { | ||
verbose: program.watch ? true : program.verbose || false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it the same as:
verbose: program.watch || program.verbose || false,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are right. My mistake. Will make an amendment. Probably today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change this today Jack, we could include this on the tomorrow release
Also, we'll need a new section in the documentation, if you are so busy to work on that I'll find some time next week to introcdee the documentation Thanks for your work mate |
@semoal I have updated the docs. I did not make new section, I have updated the CLI section in the REF. |
packages/cli/src/lingui-compile.ts
Outdated
const results = command(config, { | ||
verbose: program.verbose || false, | ||
const compile = () => command(config, { | ||
verbose: program.watch ? true : program.verbose || false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change this today Jack, we could include this on the tomorrow release
#966
I've added 2 functionalities:
--watch
forlingui extract
--watch
forlingui compile
- I think in some implementations of Lingui it can be useful.