Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --watch mode for extract and compile #974

Merged
merged 4 commits into from
Feb 23, 2021
Merged

feat: --watch mode for extract and compile #974

merged 4 commits into from
Feb 23, 2021

Conversation

jack1913
Copy link
Contributor

@jack1913 jack1913 commented Feb 9, 2021

#966

I've added 2 functionalities:

  1. --watch for lingui extract
  2. --watch for lingui compile - I think in some implementations of Lingui it can be useful.

@vercel
Copy link

vercel bot commented Feb 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/6zZYi3M9gvzzLw6RrMAoV1A7masu
✅ Preview: https://js-lingui-git-fork-jack1913-main-lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #974 (bd0eb48) into main (92a5ce7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #974   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          53       53           
  Lines        1605     1605           
  Branches      430      430           
=======================================
  Hits         1337     1337           
  Misses        156      156           
  Partials      112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a4ba9...bd0eb48. Read the comment docs.

@jack1913 jack1913 changed the title new feature: watch modes for extract and compile feat: watch modes for extract and compile Feb 9, 2021
packages/cli/src/lingui-compile.ts Show resolved Hide resolved
const results = command(config, {
verbose: program.verbose || false,
const compile = () => command(config, {
verbose: program.watch ? true : program.verbose || false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it the same as:
verbose: program.watch || program.verbose || false,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right. My mistake. Will make an amendment. Probably today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this today Jack, we could include this on the tomorrow release

packages/cli/src/lingui-extract.ts Show resolved Hide resolved
@semoal
Copy link
Contributor

semoal commented Feb 14, 2021

Also, we'll need a new section in the documentation, if you are so busy to work on that I'll find some time next week to introcdee the documentation

Thanks for your work mate

@jack1913
Copy link
Contributor Author

@semoal I have updated the docs. I did not make new section, I have updated the CLI section in the REF.

@jack1913 jack1913 requested a review from semoal February 15, 2021 08:25
const results = command(config, {
verbose: program.verbose || false,
const compile = () => command(config, {
verbose: program.watch ? true : program.verbose || false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this today Jack, we could include this on the tomorrow release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants