-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config accepts compilerBabelOptions #906
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/4jpsqnqk4 |
Codecov Report
@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 83.12% 83.12%
=======================================
Files 52 52
Lines 1570 1570
Branches 425 425
=======================================
Hits 1305 1305
Misses 157 157
Partials 108 108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and it'll definitely save lot of bundle size. We just officially no longer support Babel 6 since v3.
Anyway, let's keep it for other options as well 👍
@tricoder42 this is ready, this fixes also the catalogsMergePath warning, was just that optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's ship it 🚢
Will close #902
We won't break babel 6 users, but babel 7 could use this to modify that ASCII configuration :)