Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract accepts files as cli option #881

Merged
merged 9 commits into from
Nov 23, 2020

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Nov 23, 2020

Will close #510

I've adjusted also the help.ts function because when running yarn extract src/ --verbose was leading to confusion because params were passed also to yarn compile command.

On create-react-app example of Lingui projects results are really good:

New version with files param:

yarn extract src/ 1.47s user 0.26s system 111% cpu 1.709 total

Actual code branch without files filter:

yarn extract 4.19s user 0.33s system 135% cpu 3.345 total

@vercel
Copy link

vercel bot commented Nov 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/d8ikqj5w7
✅ Preview: https://js-lingui-git-feat-filtering-extract-by-files.lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #881 (50771fe) into main (a53e12f) will increase coverage by 0.15%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
+ Coverage   82.76%   82.91%   +0.15%     
==========================================
  Files          51       51              
  Lines        1427     1440      +13     
  Branches      392      395       +3     
==========================================
+ Hits         1181     1194      +13     
  Misses        145      145              
  Partials      101      101              
Impacted Files Coverage Δ
packages/react/src/I18nProvider.tsx 83.87% <ø> (ø)
...ackages/babel-plugin-extract-messages/src/index.ts 82.11% <50.00%> (-2.24%) ⬇️
packages/cli/src/api/catalog.ts 80.97% <100.00%> (+0.47%) ⬆️
packages/core/src/dev/loadLocaleData.ts 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84273ab...50771fe. Read the comment docs.

Copy link
Contributor

@tricoder42 tricoder42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor point, but the code works well.

packages/cli/src/api/catalog.test.ts Outdated Show resolved Hide resolved
@tricoder42 tricoder42 merged commit 82dea5f into main Nov 23, 2020
@tricoder42 tricoder42 deleted the feat-filtering-extract-by-files branch November 23, 2020 17:09
@tricoder42
Copy link
Contributor

Just another awesome feature! Good job! 👍

@semoal
Copy link
Contributor Author

semoal commented Nov 23, 2020

Just another awesome feature! Good job! 👍

We ship this tomorrow?

@tricoder42
Copy link
Contributor

We ship this tomorrow?

Let's wait a week or so and collect other fixes/features on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run lingui extract for specified files
2 participants