Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Refactoring #68

Merged
merged 21 commits into from
Aug 27, 2017
Merged

CLI Refactoring #68

merged 21 commits into from
Aug 27, 2017

Conversation

tricoder42
Copy link
Contributor

@tricoder42 tricoder42 commented Aug 27, 2017

Tracking issue to fix CLI related bugs and added requested features:

Moved to later:

@codecov
Copy link

codecov bot commented Aug 27, 2017

Codecov Report

Merging #68 into master will decrease coverage by 9.2%.
The diff coverage is 39.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   99.84%   90.64%   -9.21%     
==========================================
  Files          28       34       +6     
  Lines         652      759     +107     
==========================================
+ Hits          651      688      +37     
- Misses          1       71      +70
Impacted Files Coverage Δ
packages/lingui-conf/src/index.js 100% <ø> (ø) ⬆️
packages/lingui-i18n/src/select.js 100% <ø> (ø) ⬆️
...s/babel-plugin-lingui-transform-react/src/index.js 100% <ø> (ø) ⬆️
packages/lingui-cli/src/api/stats.js 0% <0%> (ø)
...ckages/lingui-cli/src/api/extractors/typescript.js 0% <0%> (ø)
packages/lingui-cli/src/lingui-extract.js 17.64% <17.64%> (ø)
packages/lingui-cli/src/api/extractors/babel.js 33.33% <33.33%> (ø)
packages/lingui-cli/src/api/formats/lingui.js 38.09% <38.09%> (ø)
packages/lingui-cli/src/mocks.js 75% <75%> (ø)
packages/lingui-cli/src/api/extract.js 75% <75%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b7d44...ae1e82b. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 27, 2017

Codecov Report

Merging #68 into master will decrease coverage by 9.67%.
The diff coverage is 47.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   99.84%   90.16%   -9.68%     
==========================================
  Files          28       34       +6     
  Lines         652      773     +121     
==========================================
+ Hits          651      697      +46     
- Misses          1       76      +75
Impacted Files Coverage Δ
...ckages/example-usecase/src/Usecases/NeverUpdate.js 100% <ø> (ø) ⬆️
packages/lingui-cli/src/api/compile.js 100% <ø> (ø) ⬆️
packages/lingui-react/src/I18nProvider.js 100% <ø> (ø) ⬆️
...s/babel-plugin-lingui-transform-react/src/index.js 100% <ø> (ø) ⬆️
packages/lingui-conf/src/index.js 100% <ø> (ø) ⬆️
.../example-usecase/src/Usecases/ElementAttributes.js 100% <ø> (ø) ⬆️
packages/example-usecase/src/Usecases/Children.js 100% <ø> (ø) ⬆️
packages/lingui-i18n/src/select.js 100% <ø> (ø) ⬆️
packages/lingui-cli/src/api/stats.js 0% <0%> (ø)
packages/lingui-react/src/Select.js 100% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b7d44...99dc361. Read the comment docs.

@tricoder42 tricoder42 changed the base branch from master to next August 27, 2017 19:45
@tricoder42 tricoder42 changed the title [WIP] CLI Refactoring CLI Refactoring Aug 27, 2017
@tricoder42 tricoder42 merged commit f423baf into next Aug 27, 2017
@tricoder42 tricoder42 deleted the cli-refactoring branch August 27, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant