Fix flow types on withI18n #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello guys, I don't know how that works for others but the existing flow types in withI18n throw a lot of errors in our project. I figured out that the proposed change fixes this. As far as I understand flowtype and the withI18n component, the return type is indeed `React.ComponentType<$Diff<P, withI18nProps>>` and not an intersection of `C` and the above. Please take a look if it makes sense for you too.
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
|
Deployment failed with the following error: |
|
duh.. ok Mr "now" bot, I admit, I didn't read any readme about contributing :) |
|
Thanks, this looks good! |
|
Fixed in v2.9.1. 🎉 |
|
Unfortunatelly, these changes caused few flow errors. I had to disable flow linter in If you were interested fixing it, I've created branch |
This was referenced Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
I don't know how that works for others, but the existing flow types in withI18n throw a lot of errors in our project.
I figured out that the proposed change fixes this.
As far as I understand flowtype and the withI18n component, the return type is indeed
React.ComponentType<$Diff<P, withI18nProps>>and not an intersection ofCand the above.Please take a look if it makes sense for you too.