Fix escaped backticks in macro-transformed template strings #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
=========================================
Coverage ? 91.09%
=========================================
Files ? 51
Lines ? 1415
Branches ? 0
=========================================
Hits ? 1289
Misses ? 126
Partials ? 0
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
=========================================
Coverage ? 91.09%
=========================================
Files ? 51
Lines ? 1415
Branches ? 0
=========================================
Hits ? 1289
Misses ? 126
Partials ? 0
Continue to review full report at Codecov.
|
|
It looks mostly harmless. Good job! 👍 |
|
Released in v2.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use a literal backtick in a template string (such as for markdown code blocks), it needs to be escaped (
const str = `\``;).Unfortunately, this gets picked up as
\\`due tovalue.raw, which ends up as a literal\`in the translation string.In turn, this leads to final translation strings ending up with the literal
\`, which is broken syntax, throwing aError: Can't parse message. Please check correct syntax".This PR provides a quick fix for the issue, allowing backticks to be used.