Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow leading space in i18n description comments #366

Merged
merged 2 commits into from
Oct 18, 2018
Merged

fix: allow leading space in i18n description comments #366

merged 2 commits into from
Oct 18, 2018

Conversation

Nodge
Copy link
Contributor

@Nodge Nodge commented Oct 14, 2018

lingui extract ignores messages with leading space in description comment.

Example source code:

/* i18n: description */t`Message`

Expected messages:

{
  "Message": {
    "translation": "Message",
    "description": "description",
    "origin": [
      [
        "test.js",
        1
      ]
    ]
  }
}

Actual messages:

{}

@tricoder42 tricoder42 merged commit f17c858 into lingui:master Oct 18, 2018
@Nodge Nodge deleted the spaced-description branch October 18, 2018 17:11
@tricoder42
Copy link
Contributor

Released in v2.7.1

Photonios pushed a commit to SectorLabs/js-lingui that referenced this pull request Dec 9, 2019
@Nodge @Photonios
fix: allow leading space in i18n description comments (lingui#366)
2cb3734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nodge @tricoder42 @robot-tap