Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): externalize macro imports. #1466

Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

Tell Vite to not trying to bundle macro code which is not supposed to be in browser anyway

Fixes: #1464

Tell Vite to not trying to bundle macro code which
is not supposed to be in browser anyway
@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 10:40AM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 73.23% // Head: 69.45% // Decreases project coverage by -3.78% ⚠️

Coverage data is based on head (ed31fe9) compared to base (15510c1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage   73.23%   69.45%   -3.78%     
==========================================
  Files          80       72       -8     
  Lines        3139     2148     -991     
  Branches      934      582     -352     
==========================================
- Hits         2299     1492     -807     
+ Misses        658      521     -137     
+ Partials      182      135      -47     
Impacted Files Coverage Δ
packages/vite-plugin/src/index.ts 75.00% <0.00%> (-13.24%) ⬇️
packages/cli/src/api/help.ts 10.00% <0.00%> (-43.85%) ⬇️
packages/cli/src/lingui-extract-template.ts 0.00% <0.00%> (-42.43%) ⬇️
packages/cli/src/api/extractors/babel.ts 54.54% <0.00%> (-28.79%) ⬇️
packages/cli/src/api/stats.ts 70.00% <0.00%> (-16.67%) ⬇️
packages/remote-loader/src/browserCompiler.ts 40.00% <0.00%> (-14.55%) ⬇️
packages/cli/src/lingui-extract.ts 0.00% <0.00%> (-12.77%) ⬇️
packages/macro/src/index.ts 83.87% <0.00%> (-8.09%) ⬇️
packages/remote-loader/src/index.ts 71.42% <0.00%> (-7.52%) ⬇️
packages/cli/src/lingui-compile.ts 30.58% <0.00%> (-6.26%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit 1719430 into lingui:main Feb 24, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix/vite-externalize-macro branch February 24, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite: Could not resolve "ts-node"
3 participants