Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin): ship in dual package format for compatibility with … #1450

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

Fixes: #1449

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 11:41AM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 73.33% // Head: 69.52% // Decreases project coverage by -3.82% ⚠️

Coverage data is based on head (f2739b0) compared to base (34e14cd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   73.33%   69.52%   -3.82%     
==========================================
  Files          79       72       -7     
  Lines        2903     2146     -757     
  Branches      867      581     -286     
==========================================
- Hits         2129     1492     -637     
+ Misses        617      519      -98     
+ Partials      157      135      -22     
Impacted Files Coverage Δ
packages/cli/src/api/extractors/babel.ts 54.54% <0.00%> (-33.46%) ⬇️
packages/cli/src/lingui-extract.ts 0.00% <0.00%> (-5.93%) ⬇️
packages/cli/src/api/catalog.ts 85.77% <0.00%> (-4.64%) ⬇️
...ackages/babel-plugin-extract-messages/src/index.ts 80.95% <0.00%> (-4.14%) ⬇️
packages/macro/src/index.ts 83.87% <0.00%> (-3.63%) ⬇️
packages/cli/src/api/formats/po-gettext.ts 82.53% <0.00%> (-3.50%) ⬇️
packages/cli/src/lingui-compile.ts 30.58% <0.00%> (-3.47%) ⬇️
packages/cli/src/api/utils.ts 72.50% <0.00%> (-2.08%) ⬇️
packages/jest-mocks/index.ts 95.83% <0.00%> (-1.47%) ⬇️
packages/macro/src/macroJsx.ts 90.27% <0.00%> (-1.05%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit e3a2b39 into lingui:main Feb 21, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix/vite-dual-package branch February 21, 2023 13:31
timofei-iatsenko added a commit to timofei-iatsenko/js-lingui that referenced this pull request Feb 24, 2023
andrii-bodnar pushed a commit that referenced this pull request Feb 24, 2023
* Revert "fix(vite-plugin): ship in dual package format for compatibility with Vite (#1450)"

* fix(vite-plugin): change default export to named export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite plugin -> lingui is not a function in new Vite + React + TS project
3 participants