fix(cli): incorrect main entry in package.json #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
andrii-bodnar
approved these changes
Jan 20, 2023
|
That's wrong fix, you exposed something which should not be exposed. To make it Right you should delete Your fix saying is literally saying "hey, I have consumable entrypoint" for everyone, which actually is not. Also report for CLI on bundlephobia is useless, no one is going to actually bundle a cli tool |
|
makes sense 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect
mainentry inpackage.jsonof@lingui/cli. This was causing Bundlephobia to reportEntryPointErroron the new 3.16.0 version of the package.