fix: Allow pseudoLocalize to work in @lingui/loader #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lingui/loader uses strict mode when it's not running in production. This is turn means that `compileSingleKey` always gets passed an empty string as `translation` for the pseudo locale to translate. This seems to defeat the purpose of using pseudo localization. With this change, you can use @lingui/loader and also get dynamically generated pseudo locale string.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/EGPTtzbm62HZLUyUmDYyXiwHupYG |
ggascoigne
changed the title
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lingui/loader uses strict mode when it's not running in production. This is turn means that
compileSingleKeyalways gets passed an empty string astranslationfor the pseudo locale to translate. This seems to defeat the purpose of using pseudo localization.With this change, you can use @lingui/loader and also get dynamically generated pseudo locale string.