Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing babel properties to config validation #1135

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

JSteunou
Copy link
Contributor

@JSteunou JSteunou commented Sep 15, 2021

targets browserslistconfigfile browserslistenv assumptions was missing in validation, fixes #1133

`targets` and `assumptions` was missing in validation, fixes lingui#1133
@vercel
Copy link

vercel bot commented Sep 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/2SRJ9bTfCHuXBP5vVP5i8kieqVin
✅ Preview: https://js-lingui-git-fork-jsteunou-patch-2-lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1135 (27f564d) into main (1c6378d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          56       56           
  Lines        1687     1687           
  Branches      462      462           
=======================================
  Hits         1385     1385           
  Misses        176      176           
  Partials      126      126           
Impacted Files Coverage Δ
packages/conf/src/index.ts 79.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea43886...27f564d. Read the comment docs.

@semoal
Copy link
Contributor

semoal commented Sep 27, 2021

LGTM, thanks for contributing =)

@JSteunou
Copy link
Contributor Author

You're welcome, thank you for your effort on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird warning about babel configuration from lingui
2 participants