Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config accepts compilerBabelOptions #906

Merged
merged 6 commits into from
Dec 8, 2020
Merged

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Dec 7, 2020

Will close #902

We won't break babel 6 users, but babel 7 could use this to modify that ASCII configuration :)

@vercel
Copy link

vercel bot commented Dec 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/4jpsqnqk4
✅ Preview: https://js-lingui-git-feat-compiler-babel-options.lingui-js.now.sh

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #906 (2724e9c) into main (a3b5bcb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files          52       52           
  Lines        1570     1570           
  Branches      425      425           
=======================================
  Hits         1305     1305           
  Misses        157      157           
  Partials      108      108           
Impacted Files Coverage Δ
packages/conf/src/index.ts 87.14% <ø> (ø)
packages/cli/src/api/compile.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b5bcb...2724e9c. Read the comment docs.

Copy link
Contributor

@tricoder42 tricoder42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and it'll definitely save lot of bundle size. We just officially no longer support Babel 6 since v3.

Anyway, let's keep it for other options as well 👍

@tricoder42 tricoder42 mentioned this pull request Dec 7, 2020
@semoal
Copy link
Contributor Author

semoal commented Dec 8, 2020

@tricoder42 this is ready, this fixes also the catalogsMergePath warning, was just that optional ? type.

Copy link
Contributor

@tricoder42 tricoder42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's ship it 🚢

@semoal semoal merged commit 38d01ef into main Dec 8, 2020
@semoal semoal deleted the feat-compiler-babel-options branch December 8, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with utf chars
2 participants