Include wasmer-types in workspace with indexmap 2#10
Open
deuszx wants to merge 2 commits intofix-rust-probestackfrom
Open
Include wasmer-types in workspace with indexmap 2#10deuszx wants to merge 2 commits intofix-rust-probestackfrom
deuszx wants to merge 2 commits intofix-rust-probestackfrom
Conversation
deuszx
commented
Mar 10, 2026
deuszx
commented
- Uncomment lib/types as workspace member
- Change wasmer-types workspace dep to path dependency
- Update lib/types indexmap from 1.6 to workspace (indexmap 2)
- Update serde feature name from serde-1 to serde (indexmap 2)
- Remove rkyv indexmap feature (incompatible with indexmap 2)
- Remove rkyv strict feature (blocks tuple Archive impls)
- Convert ArchivableModuleInfo IndexMap fields to Vec<(K, V)> with conversion in From impls, since rkyv 0.7 doesn't support indexmap 2 serialization
- Update rust-toolchain to 1.93.1 (indexmap 2.13 requires 1.82+)
- Uncomment lib/types as workspace member - Change wasmer-types workspace dep to path dependency - Update lib/types indexmap from 1.6 to workspace (indexmap 2) - Update serde feature name from serde-1 to serde (indexmap 2) - Remove rkyv indexmap feature (incompatible with indexmap 2) - Remove rkyv strict feature (blocks tuple Archive impls) - Convert ArchivableModuleInfo IndexMap fields to Vec<(K, V)> with conversion in From impls, since rkyv 0.7 doesn't support indexmap 2 serialization - Update rust-toolchain to 1.93.1 (indexmap 2.13 requires 1.82+)
Both crates had direct indexmap 1.6 dependencies that conflicted with wasmer-types now using indexmap 2.
|
What's the reason for this PR? Does the old |
Author
|
There was sth about the indexmap @ 1.6 failing to include the build-std for the custom target ( |
|
You mean |
|
I see, this is for linera-io/linera-protocol#5650. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.