-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update Rust tolchains #5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Update Rust tolchains #5554
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2fbed25
Update to Rust 1.93.1 toolchain
deuszx 488b867
Clippy
deuszx c6da5f2
Regenerate lock files
deuszx 6b0861a
Merge remote-tracking branch 'origin/testnet_conway' into issue-5264
deuszx b4cd98b
Fix compilation
deuszx dfc2208
Fix CI failures: sha3 deprecated as_slice, taplo format, and cargo-ma…
deuszx c99dda3
Clippy
deuszx 53cdf1b
Bump nightly toolchain
deuszx 7ae3256
Fix type inference error in llm example after sha3 GenericArray API c…
deuszx 111348e
Replace index() with enumerate
deuszx cf92b29
Disable bulk-memory and nontrapping-fptoint Wasm opcodes (0xFC) for c…
deuszx eb70a86
Fix 0xFC wasm opcodes not being suppressed when RUSTFLAGS is set
deuszx 90e2324
Use custom wasm32-mvp target to eliminate 0xFC opcodes for testnet_co…
deuszx f56cc81
Update README files
deuszx 1870d00
Add new target to .cargo/config.toml
deuszx c4f1921
RM test that cna't run in the CI
deuszx 607c94b
Install the toolchain in CliWrapper::build_application
deuszx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| [target.aarch64-unknown-linux-gnu] | ||
| linker = "aarch64-linux-gnu-gcc" | ||
|
|
||
| [env] | ||
| # Makes `--target wasm32-mvp` resolve to linera-service/wasm32-mvp.json | ||
| # anywhere in the repo. | ||
| RUST_TARGET_PATH = { value = "linera-service", relative = true } | ||
|
|
||
| [build] | ||
| # We allow redundant explicit links because `cargo rdme` doesn't know how to resolve implicit intra-crate links. | ||
| rustdocflags = ["-Arustdoc::redundant_explicit_links"] | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [build] | ||
| # Required for rustc to accept the custom wasm32-mvp target spec. | ||
| rustflags = ["-Zunstable-options"] | ||
|
|
||
| [unstable] | ||
| build-std = ["std", "panic_abort"] | ||
| json-target-spec = true |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than using
wasm32-mvp, let's add two targets that we can distinguish:wasm32-linera-chainfor on-chain applications (contract and service)wasm32-unknown-js-webfor the Web browser (@linera/client)Then we can throw away the
webfeatures that are currently polluting our codebase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'll suggest one target for both contract and service, even though it might be cleaner to separate them, because it eases compilation of applications for the end-user)