Send NewRound notifications after proposals.#4473
Merged
afck merged 2 commits intolinera-io:mainfrom Sep 3, 2025
Merged
Conversation
deuszx
reviewed
Sep 3, 2025
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 4, 2025
## Motivation `NewRound` notifications are mainly needed for single-leader mode, where they are triggered by timeout certificates. However, in multi-leader mode, in case of failed proposals, they are also useful, so that the other owners can avoid making a conflicting proposal in the same round. ## Proposal Send `NewRound` notifications in `handle_block_proposal`, too. ## Test Plan An assertion was added to a worker test. ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - Closes linera-io#4472. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Closed
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation `NewRound` notifications are mainly needed for single-leader mode, where they are triggered by timeout certificates. However, in multi-leader mode, in case of failed proposals, they are also useful, so that the other owners can avoid making a conflicting proposal in the same round. ## Proposal Send `NewRound` notifications in `handle_block_proposal`, too. ## Test Plan An assertion was added to a worker test. ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - Closes #4472. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation `NewRound` notifications are mainly needed for single-leader mode, where they are triggered by timeout certificates. However, in multi-leader mode, in case of failed proposals, they are also useful, so that the other owners can avoid making a conflicting proposal in the same round. ## Proposal Send `NewRound` notifications in `handle_block_proposal`, too. ## Test Plan An assertion was added to a worker test. ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - Closes #4472. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NewRoundnotifications are mainly needed for single-leader mode, where they are triggered by timeout certificates.However, in multi-leader mode, in case of failed proposals, they are also useful, so that the other owners can avoid making a conflicting proposal in the same round.
Proposal
Send
NewRoundnotifications inhandle_block_proposal, too.Test Plan
An assertion was added to a worker test.
Release Plan
Links
NewRoundnotifications. #4472.