Extract send_timing method; log errors.#4463
Merged
afck merged 1 commit intolinera-io:mainfrom Sep 2, 2025
Merged
Conversation
ma2bd
approved these changes
Sep 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 4, 2025
## Motivation We try to avoid `let _ =` in general: linera-io#4413 (comment) ## Proposal Deduplicate the code to send timing information in the chain client implementation, and log a warning if sending fails. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (Would be no problem to backport.) ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Closed
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation We try to avoid `let _ =` in general: #4413 (comment) ## Proposal Deduplicate the code to send timing information in the chain client implementation, and log a warning if sending fails. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (Would be no problem to backport.) ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation We try to avoid `let _ =` in general: #4413 (comment) ## Proposal Deduplicate the code to send timing information in the chain client implementation, and log a warning if sending fails. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (Would be no problem to backport.) ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We try to avoid
let _ =in general: #4413 (comment)Proposal
Deduplicate the code to send timing information in the chain client implementation, and log a warning if sending fails.
Test Plan
CI
Release Plan
Links