Merged
Conversation
linera-base/src/identifiers.rs
Outdated
| /// 20-byte account EVM-compatible address. | ||
| #[debug(with = "hex_debug")] | ||
| Address20([u8; 20]), | ||
| Address20(#[debug(with = "hex_debug")] [u8; 20]), |
Contributor
There was a problem hiding this comment.
I would add a test for Address20 as well as Address32 (which I assume is correct right now, just unsure because of a lack of test).
Contributor
Author
There was a problem hiding this comment.
Good idea! Turns out:
- For
Address32we only print 8 bytes because of theDebugimpl forCryptoHash. I guess I should change that, too, and print the whole hash. - For
Reserved, we print it in decimal. I guess that's okay, although I'd prefer hexadecimal there, too.
Contributor
There was a problem hiding this comment.
For Reserved, we currently have only 0 as a possibility.
This corresponds to CHAIN, so I guess that we can do something here as well.
Contributor
Author
There was a problem hiding this comment.
Done in c0f8469; but now I'm a bit worried that this will make other log lines more spammy, because now all hashes are four times as long.
(I'll leave changing the representation of Reserved(0) for a later PR; not sure about that.)
Contributor
Author
There was a problem hiding this comment.
As discussed, let's print only 8 bytes for both variants instead.
MathieuDutSik
approved these changes
Sep 1, 2025
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 4, 2025
## Motivation `AccountOwner::Address20`'s `Debug` impl prints something like: ``` Address20([10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10]) ``` because the `hex_debug` attribute is in the wrong place. ## Proposal Put the attribute directly on the field, not the enum variant. The `Debug` impl now says: ``` Address20(0a0a0a0a0a0a0a0a..) ``` ## Test Plan Tried it locally. ## Release Plan - Should be backported to testnet and devnet. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Closed
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation `AccountOwner::Address20`'s `Debug` impl prints something like: ``` Address20([10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10]) ``` because the `hex_debug` attribute is in the wrong place. ## Proposal Put the attribute directly on the field, not the enum variant. The `Debug` impl now says: ``` Address20(0a0a0a0a0a0a0a0a..) ``` ## Test Plan Tried it locally. ## Release Plan - Should be backported to testnet and devnet. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation `AccountOwner::Address20`'s `Debug` impl prints something like: ``` Address20([10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10]) ``` because the `hex_debug` attribute is in the wrong place. ## Proposal Put the attribute directly on the field, not the enum variant. The `Debug` impl now says: ``` Address20(0a0a0a0a0a0a0a0a..) ``` ## Test Plan Tried it locally. ## Release Plan - Should be backported to testnet and devnet. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AccountOwner::Address20'sDebugimpl prints something like:because the
hex_debugattribute is in the wrong place.Proposal
Put the attribute directly on the field, not the enum variant. The
Debugimpl now says:Test Plan
Tried it locally.
Release Plan
Links