Don't fail if faucet chain was opened but old one not closed.#3864
Closed
afck wants to merge 2 commits intolinera-io:testnet_babbagefrom
Closed
Don't fail if faucet chain was opened but old one not closed.#3864afck wants to merge 2 commits intolinera-io:testnet_babbagefrom
afck wants to merge 2 commits intolinera-io:testnet_babbagefrom
Conversation
afck
added a commit
that referenced
this pull request
May 5, 2025
## Motivation Automatic faucet chain rotation caused several issues. (See e.g. #3864.) ## Proposal Revert it. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Contributor
Author
|
This approach to faucet rotation was reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On the testnet, for some reason the faucet failed to close the old chain after migrating to a new one.
Proposal
Make the faucet handle that case on startup: Also migrate if the old chain has no tokens, even if it is not closed.
Test Plan
A new test for all these cases was added.
Release Plan
a3edc33d8e951a1139333be8a4b56646b5598a8f51216e86592d881808972b07chain.Links