Automatically rotate the faucet chain once it has a maximum length.#3848
Merged
afck merged 2 commits intolinera-io:mainfrom Apr 29, 2025
Merged
Automatically rotate the faucet chain once it has a maximum length.#3848afck merged 2 commits intolinera-io:mainfrom
afck merged 2 commits intolinera-io:mainfrom
Conversation
christos-h
reviewed
Apr 29, 2025
| .await | ||
| .update_wallet_for_new_chain( | ||
| chain_id, | ||
| Some(key_pair), |
Contributor
There was a problem hiding this comment.
We use the same keypair on child chains?
Contributor
Author
There was a problem hiding this comment.
It was easiest to do it that way, and maybe it's also better: That way you don't have to keep backing up new key pairs.
Contributor
There was a problem hiding this comment.
This will change in a moment with the new Signer abstraction anyway.
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Apr 29, 2025
…inera-io#3848) ## Motivation If the faucet chain gets very long, requesting a new chain becomes very slow for new wallets. ## Proposal Make the faucet switch chains every 100 blocks. ## Test Plan I extended `test_end_to_end_faucet_with_long_chains`. ## Release Plan - Nothing to do / These changes follow the usual release cycle. - These changes should be backported to the latest `testnet` branch, then - be deployed as the faucet. ## Links - Closes linera-io#3846. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
afck
added a commit
that referenced
this pull request
Apr 29, 2025
…3848) (#3852) Backport of #3848. ## Motivation If the faucet chain gets very long, requesting a new chain becomes very slow for new wallets. ## Proposal Make the faucet switch chains every 100 blocks. ## Test Plan I extended `test_end_to_end_faucet_with_long_chains`. ## Release Plan - These changes should be deployed as the faucet. ## Links - Backport of #3848. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Apr 30, 2025
…ength. (linera-io#3848) (linera-io#3852)" This reverts commit 026f601.
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
May 5, 2025
…ength. (linera-io#3848)" This reverts commit 3263682.
afck
added a commit
that referenced
this pull request
May 5, 2025
## Motivation The current approach to automatic faucet chain rotation doesn't work well. In particular, it closes the original chain, so restarts don't work with the same command line arguments. ## Proposal Revert #3848. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - Reverted PR: #3848 - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the faucet chain gets very long, requesting a new chain becomes very slow for new wallets.
Proposal
Make the faucet switch chains every 100 blocks.
Test Plan
I extended
test_end_to_end_faucet_with_long_chains.Release Plan
testnetbranch, thenLinks