Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
bart-linera
approved these changes
Apr 23, 2025
MathieuDutSik
approved these changes
Apr 23, 2025
Contributor
MathieuDutSik
left a comment
MathieuDutSik
left a comment
There was a problem hiding this comment.
It looks totally safe to merge.
It seems that the pub-sub channels were not tested that much.
Contributor
Author
They were, until I ported the |
Kaydee20
added a commit
to Kaydee20/linera-protocol
that referenced
this pull request
Apr 28, 2025
remove sub channels and enable clicks linera-io#3793 Signed-off-by: Khadijat <36544539+Kaydee20@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With #3784, pub-sub channels are no longer needed.
Proposal
Remove them, and the types
ChannelName,Origin,Target,Medium,Destination, etc.Test Plan
CI
Release Plan
Links