Merged
Conversation
deuszx
approved these changes
Apr 13, 2025
Contributor
deuszx
left a comment
deuszx
left a comment
There was a problem hiding this comment.
Apart from the comments/rename - LGTM.
afck
approved these changes
Apr 13, 2025
| description.genesis_config_hash, genesis_config_hash | ||
| ); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Here it might be useful to also print both network names. (Also below.)
Contributor
Author
There was a problem hiding this comment.
Mmm I'm going to send another PR for this.
ma2bd
force-pushed
the
network_information
branch
2 times, most recently
from
0dc33c4 to
c31beab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently pass around a genesis configuration when deploying a validator but this is not really needed.
This is the first step to simplify things.
Proposal
NetworkInformationwhile we're at it.Incidentally, we won't compute the genesis config hash over and over again.
Test Plan
CI
Release Plan