Remove event subscription functions from contract runtime.#3725
Merged
afck merged 1 commit intolinera-io:mainfrom Apr 7, 2025
Merged
Remove event subscription functions from contract runtime.#3725afck merged 1 commit intolinera-io:mainfrom
afck merged 1 commit intolinera-io:mainfrom
Conversation
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Apr 16, 2025
…inera-io#3725)" This reverts commit 572b293.
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Apr 17, 2025
…inera-io#3725)" This reverts commit 572b293.
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Apr 22, 2025
…inera-io#3725)" This reverts commit 572b293.
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Apr 23, 2025
…inera-io#3725)" This reverts commit 572b293.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #3692 I added basic user events, but subscriptions are not implemented yet. However, I optimistically added the contract runtime functions for subscriptions in that PR, too, so they are now user-visible but don't work yet.
Proposal
Remove them from the contract runtime, so that if we release a new SDK, they don't show up yet.
Test Plan
CI
Release Plan
Links