Merged
Conversation
deuszx
reviewed
Mar 24, 2025
| message.grant == Amount::ZERO, | ||
| ChainError::GrantUseOnBroadcast | ||
| ); | ||
| let GenericApplicationId::User(application_id) = |
Contributor
There was a problem hiding this comment.
Is GenericApplicationId::System used anywhere else now?
deuszx
approved these changes
Mar 24, 2025
afck
added a commit
that referenced
this pull request
Mar 25, 2025
## Motivation `SystemMessage::Subscribe` and `Unsubscribe` were only used for system channels, which are now gone. ## Proposal Remove them, and the `subscribers` collection in the system execution state view. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - System channels were removed in #3634. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As of #3432 we are not using system channels anymore.
Proposal
Remove the
SystemChanneltype and any system channel-specific logic, in particular the "off-chain subscription handling".Test Plan
The
socialexample tests make sure that user pub-sub channels still work.Release Plan
Links