Transfer command uses AccountOwner type.#3573
Merged
Conversation
deuszx
force-pushed
the
transfer-use-accountowner-type
branch
2 times, most recently
from
493adfa to
eef4aff
Compare
deuszx
force-pushed
the
transfer-use-accountowner-type
branch
from
eef4aff to
9aee4a1
Compare
jvff
approved these changes
Mar 14, 2025
deuszx
force-pushed
the
cleanup-account-owner-chain
branch
from
9a67aed to
b6110b9
Compare
deuszx
force-pushed
the
transfer-use-accountowner-type
branch
from
9aee4a1 to
3ab8c5a
Compare
ma2bd
reviewed
Mar 16, 2025
| block.with_native_token_transfer(Some(owner), Recipient::Burn, transfer_amount); | ||
| block.with_native_token_transfer( | ||
| AccountOwner::User(owner), | ||
| Recipient::Burn, |
Contributor
There was a problem hiding this comment.
We can probably kill this Burn thing by the way and simplify (away?) Recipient now. People will be able to send to address 0x0 (or anything really) if they really want to burn tokens.
ma2bd
approved these changes
Mar 16, 2025
afck
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Continuation of the cleanup.
Proposal
Transfercommand now usesAccountOwner::Chainin place whereNonewas used.Test Plan
CI
Release Plan
Links