Merged
Conversation
Don't condition it to having depleted its expected calls.
Allow writing tests where the application calls its service as an oracle.
jvff
force-pushed
the
epoch-configurable-http-timeouts
branch
from
4cec7ea to
20932c5
Compare
Allow configuring the timeout for HTTP requests.
Ensure that it takes a bounded amount of time to complete.
jvff
force-pushed
the
epoch-configurable-http-timeouts
branch
from
20932c5 to
f74cb21
Compare
afck
approved these changes
Mar 11, 2025
| .send() | ||
| .await?; | ||
| .headers(headers); | ||
| #[cfg(not(web))] |
Contributor
There was a problem hiding this comment.
…or use the same timeout in either case? Might be less surprising, too.
Contributor
Author
There was a problem hiding this comment.
We can't, reqwest doesn't support timeouts on Wasm :/
deuszx
reviewed
Mar 11, 2025
|
|
||
| let response = Client::new() | ||
| #[cfg_attr(web, allow(unused_mut))] | ||
| let mut request = Client::new() |
Contributor
There was a problem hiding this comment.
So on a web client there won't be any timeouts?
Contributor
Author
There was a problem hiding this comment.
Only the default browser timeouts. Unfortunately we can't add timeouts with reqwest for Wasm, we'd need to use Javascript APIs directly :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HTTP requests can take a long time to complete, or attempt to stay open indefinitely. This should not be allowed because it may stall a chain.
Proposal
Add a
http_request_timeoutpolicy toResourceControlPolicy, and configure all HTTP requests to use that timeout.Test Plan
Wrote some tests out of this branch, possibly to be added to #3509.
Release Plan
devnetandtestnetand release a newSDK soon, because this contains backwards incompatible changes to the chain state.
Links